Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sensor groups inverter model aware #309

Closed
wants to merge 2 commits into from
Closed

Make sensor groups inverter model aware #309

wants to merge 2 commits into from

Conversation

rixxxx
Copy link
Contributor

@rixxxx rixxxx commented Jul 1, 2024

Make sensor groups inverter model aware. Some grid and battery sensor names differ between 1ph, 3ph and 3ph HV models.

Gets rid of annoying messages about missing sensors.
sunsynk-1 | 19:37:45 ERROR Unknown sensor specified: aux_power
sunsynk-1 | 19:37:45 ERROR Unknown sensor specified: essential_power
sunsynk-1 | 19:37:45 ERROR Unknown sensor specified: grid_voltage
sunsynk-1 | 19:37:45 ERROR Unknown sensor specified: inverter_current
sunsynk-1 | 19:37:45 ERROR Unknown sensor specified: load_frequency
sunsynk-1 | 19:37:45 ERROR Unknown sensor specified: non_essential_power

@rixxxx rixxxx mentioned this pull request Jul 1, 2024
Open
@kellerza kellerza closed this Jul 4, 2024
@kellerza kellerza reopened this Jul 4, 2024
Repository owner deleted a comment from codecov bot Jul 4, 2024
@kellerza
Copy link
Owner

kellerza commented Jul 4, 2024

Thanks @rixxxx

I made some changes in 2db1d0d which should stop the warnings being issued if sensors in a group is not part of the current definitions. At also adds an "all" group.

Mayb you can extend the definitions further to include all the 3PH sensors?

@kellerza kellerza closed this Jul 4, 2024
Repository owner deleted a comment from codecov bot Jul 4, 2024
@rixxxx
Copy link
Contributor Author

rixxxx commented Jul 4, 2024

Sure, I'll have a look.

@rixxxx
Copy link
Contributor Author

rixxxx commented Jul 4, 2024

Now I get:
sunsynk-1 | 17:00:14 ERROR Your config includes deprecated sensors. Replace battery_current with battery_1_current
sunsynk-1 | 17:00:14 ERROR Your config includes deprecated sensors. Replace battery_power with battery_1_power
sunsynk-1 | 17:00:14 ERROR Your config includes deprecated sensors. Replace battery_soc with battery_1_soc

battery_current, battery_power and battery_soc get pulled in by power_flow_card. My intention with this PR was to load unnumbered battery sensors only for 1PH and 3PH LV.

@kellerza
Copy link
Owner

kellerza commented Jul 4, 2024

b86cdf1

@rixxxx
Copy link
Contributor Author

rixxxx commented Jul 4, 2024

👏

@rixxxx rixxxx deleted the separate-sensor-groups branch September 5, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rixxxx @kellerza